Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Feat/polkadot v0.9.43 uplift #978

Merged
merged 33 commits into from
Jul 26, 2023
Merged

Feat/polkadot v0.9.43 uplift #978

merged 33 commits into from
Jul 26, 2023

Conversation

Dinonard
Copy link
Member

@Dinonard Dinonard commented Jul 17, 2023 •
edited
Loading

Pull Request Summary

Uplift from polkadot-v0.9.40 to polkadot-v0.9.43.

Notable Changes

Client

Runtime

Test

Astar Docs Update

Check list

  • update Astar docs with CLI changes
  • update Astar docs with AccountId32 derivation scheme changes
  • follow-up tasks for Currency deprecation
  • follow-up task for XCM emulator
  • follow-up task to potentially remove TxPool vendor code
  • follow-up task to investigate EVM node with SQL backend for performance boost
  • remove TxPool from rpc.rs when evm-tracing isn't enabled?
  • re-run benchmarks (especially for pallet-xcm)
  • pallet-ethereum-checked and pallet-xvm adaptation for EVM PoV size
  • check values of DefaultDepositLimit in production runtimes
  • revise bare call for EVM in all runtimes - perhaps a better approach exists?
  • added or updated unit tests
  • account migration script for AccountInfo refactoring?
  • updated Astar official documentation
  • updated spec version
  • updated semver

@Dinonard Dinonard added shiden related to shiden runtime astar Related to Astar shibuya related to shibuya runtime This PR/Issue is related to the topic “runtime”. client This PR/Issue is related to the topic “client”. labels Jul 17, 2023
@Dinonard Dinonard self-assigned this Jul 17, 2023
@Dinonard Dinonard marked this pull request as ready for review July 19, 2023 14:55
shaunxw
shaunxw reviewed Jul 21, 2023
View reviewed changes
bin/collator/src/rpc.rs Outdated Show resolved Hide resolved
chain-extensions/pallet-assets/src/lib.rs Outdated Show resolved Hide resolved
chain-extensions/xvm/src/lib.rs Show resolved Hide resolved
runtime/local/src/lib.rs Outdated Show resolved Hide resolved
@Dinonard Dinonard mentioned this pull request Jul 24, 2023
Closed
@Dinonard
Copy link
Member Author

/bench astar-dev pallet_xcm

@github-actions
Copy link

Benchmarks job is scheduled at https://github.com/AstarNetwork/Astar/actions/runs/5642961832.
Please wait for a while.
Branch: feat/polkadot-v0.9.43-uplift
SHA: c393846

@github-actions
Copy link

Benchmarks have been finished.
You can download artifacts if exists https://github.com/AstarNetwork/Astar/actions/runs/5642961832.

@Dinonard Dinonard mentioned this pull request Jul 24, 2023
Merged
3 tasks
@github-actions
Copy link

Code Coverage

Package Line Rate Branch Rate Health
chain-extensions/pallet-assets/src 0% 0% ❌
pallets/collator-selection/src 69% 0% ➖
precompiles/sr25519/src 79% 0% ➖
chain-extensions/types/assets/src 0% 0% ❌
primitives/src 69% 0% ➖
precompiles/dapps-staking/src 93% 0% ✔
pallets/contracts-migration/src 0% 0% ❌
primitives/src/xcm 67% 0% ➖
pallets/block-reward/src 85% 0% ✔
chain-extensions/types/xvm/src 0% 0% ❌
pallets/dapps-staking/src 81% 0% ✔
pallets/pallet-xvm/src/pallet 8% 0% ❌
pallets/xc-asset-config/src 54% 0% ➖
chain-extensions/xvm/src 0% 0% ❌
pallets/ethereum-checked/src 48% 0% ❌
pallets/pallet-xvm/src 5% 0% ❌
pallets/dapps-staking/src/pallet 85% 0% ✔
precompiles/xcm/src 84% 0% ✔
chain-extensions/dapps-staking/src 0% 0% ❌
precompiles/xvm/src 61% 0% ➖
pallets/custom-signatures/src 51% 0% ➖
precompiles/assets-erc20/src 76% 0% ➖
precompiles/substrate-ecdsa/src 78% 0% ➖
precompiles/utils/macro/src 0% 0% ❌
pallets/pallet-xcm/src 53% 0% ➖
chain-extensions/types/dapps-staking/src 0% 0% ❌
precompiles/utils/src 70% 0% ➖
Summary 55% (2267 / 4149) 0% (0 / 0) ➖

Minimum allowed line rate is 50%

shaunxw
shaunxw approved these changes Jul 26, 2023
View reviewed changes
Copy link
Member

@shaunxw shaunxw left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

ashutoshvarma
ashutoshvarma approved these changes Jul 26, 2023
View reviewed changes
Copy link
Member

@ashutoshvarma ashutoshvarma left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@Dinonard Dinonard merged commit b83fea8 into master Jul 26, 2023
12 checks passed
@Dinonard Dinonard deleted the feat/polkadot-v0.9.43-uplift branch July 26, 2023 08:40
@imstar15 imstar15 mentioned this pull request Dec 8, 2023
Merged
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@ashutoshvarma ashutoshvarma ashutoshvarma approved these changes

@shaunxw shaunxw shaunxw approved these changes

@gitofdeepanshu gitofdeepanshu Awaiting requested review from gitofdeepanshu

Assignees

@Dinonard Dinonard

Labels
astar Related to Astar client This PR/Issue is related to the topic “client”. runtime This PR/Issue is related to the topic “runtime”. shibuya related to shibuya shiden related to shiden runtime
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@Dinonard @shaunxw @ashutoshvarma